Changes BookmarkBarView to only create buttons as needed

chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 267 matching lines @@
   // Creates recent bookmark button and when visible button as well as
   // calculating the preferred height.
   void Init();
 
   // NOTE: unless otherwise stated all methods that take an int for an index are
   // in terms of the bookmark bar view. Typically the view index and model index
   // are the same, but they may differ during animations or drag and drop.
   //
   // It's easy to get the mapping wrong. For this reason all these methods are
   // private.
-
-  // Returns the number of buttons corresponding to starred urls/folders. This
-  // is equivalent to the number of children the bookmark bar node from the
-  // bookmark bar model has.
+  //

[msw, 2014/10/27 22:50:18]

I don't think these two comment blocks should be joined.

[sky, 2014/10/27 23:00:49]

Done.

[msw, 2014/10/27 23:06:00]

nit: (still joined)

[sky, 2014/10/27 23:13:58]

GAH! Sorry, misunderstood your comment. fixed.

+  // Returns the number of buttons corresponding to starred urls/folders.
+  // Buttons

[msw, 2014/10/27 22:50:18]

What? Fix this sentence of the comment. Overall, I'd also suggest something like
"Returns the number of bookmark bar url/folder buttons that have been created.
This does not necessarily represent the number of bookmark bar nodes, nor the
number of visible bookmark bar buttons. Buttons are created lazily to fill
available space, and may be hidden for ordering or sizing changes."

I'm trying to convey: #(visible buttons) <= #GetBookmarkButtonCount() <=
#(bookmark bar model buttons).

[sky, 2014/10/27 23:00:49]

Done.

+  // are lazily as necessary to fill available space. As such, the return value
+  // is often times less than that of the model.
   int GetBookmarkButtonCount() const;
 
   // Returns the button at the specified index.
   views::LabelButton* GetBookmarkButton(int index);
 
   // Returns BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR or
   // BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR based on detached state.
   BookmarkLaunchLocation GetBookmarkLaunchLocation() const;
 
   // Returns the index of the first hidden bookmark button. If all buttons are
@@ skipping 155 matching lines @@
 
   ObserverList<BookmarkBarViewObserver> observers_;
 
   // Factory used to delay showing of the drop menu.
   base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_