Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 677443002: Deterministic recipe: Remove the PDBs from the list of files to compare. (Closed)

Created:
6 years, 2 months ago by Sébastien Marchand
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Deterministic recipe: Remove the PDBs from the list of files to compare. There's a lot of work to do if we want those file to be deterministic, in particular there's a lot of name tables in them that seems to have a random order (there might be a random seed somewhere...). For base_unittests, almost all of the 1219 streams included in the PDB are different... BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
PTAL. This is the only way to get a green builder on Windows in the ...
6 years, 2 months ago (2014-10-23 15:06:16 UTC) #2
M-A Ruel
snif, lgtm I'll have to plan something to allow non deterministic data in task deduplication.
6 years, 2 months ago (2014-10-23 15:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677443002/1
6 years, 2 months ago (2014-10-23 15:53:16 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 15:53:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292627

Powered by Google App Engine
This is Rietveld 408576698