scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py - Issue 677443002: Deterministic recipe: Remove the PDBs from the list of files to compare.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

Issue 677443002: Deterministic recipe: Remove the PDBs from the list of files to compare. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

diff --git a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

index a806f0d39d2743c42f630558c006ac29d63480f5..1c3095e1094a94da2cfdb9cec167ee41f83c22ea 100644

--- a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

+++ b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

@@ -17,7 +17,7 @@ BASE_DIR = os.path.dirname(os.path.abspath(__file__))

def get_files_to_compare(build_dir):

"""Get the list of files to compare."""

allowed = frozenset(

- ('', '.app', '.dll', '.dylib', '.exe', '.nexe', '.pdb', '.so'))

+ ('', '.app', '.dll', '.dylib', '.exe', '.nexe', '.so'))

def check(f):

if not os.path.isfile(f):

« no previous file with comments | « no previous file | no next file » | no next file with comments »