Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 67743006: Do not recompile existing functions when enabling allocation tracking (Closed)

Created:
7 years, 1 month ago by yurys
Modified:
7 years, 1 month ago
CC:
v8-dev, alph
Visibility:
Public.

Description

Do not recompile existing functions when enabling allocation tracking Now that we don't have special hooks for the allocations in the generated code there is no need to recompile existing functions when enabling allocation tracking. BUG=chromium:27798 LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M src/heap-profiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap-profiler.cc View 3 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 1 month ago (2013-11-19 03:18:54 UTC) #1
loislo
lgtm
7 years, 1 month ago (2013-11-19 04:03:54 UTC) #2
Michael Starzinger
LGTM.
7 years, 1 month ago (2013-11-19 16:07:17 UTC) #3
yurys
7 years, 1 month ago (2013-11-20 14:57:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698