Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/heap-profiler.cc

Issue 67743006: Do not recompile existing functions when enabling allocation tracking (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-profiler.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009-2010 the V8 project authors. All rights reserved. 1 // Copyright 2009-2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 #include "v8.h"
29 29
30 #include "deoptimizer.h"
31 #include "heap-profiler.h" 30 #include "heap-profiler.h"
32 #include "heap-snapshot-generator-inl.h" 31 #include "heap-snapshot-generator-inl.h"
33 32
34 namespace v8 { 33 namespace v8 {
35 namespace internal { 34 namespace internal {
36 35
37 HeapProfiler::HeapProfiler(Heap* heap) 36 HeapProfiler::HeapProfiler(Heap* heap)
38 : snapshots_(new HeapSnapshotsCollection(heap)), 37 : snapshots_(new HeapSnapshotsCollection(heap)),
39 next_snapshot_uid_(1), 38 next_snapshot_uid_(1),
40 is_tracking_allocations_(false) { 39 is_tracking_allocations_(false) {
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 RetainedObjectInfo* info) { 152 RetainedObjectInfo* info) {
154 // TODO(yurus, marja): Don't route this information through GlobalHandles. 153 // TODO(yurus, marja): Don't route this information through GlobalHandles.
155 heap()->isolate()->global_handles()->SetRetainedObjectInfo(id, info); 154 heap()->isolate()->global_handles()->SetRetainedObjectInfo(id, info);
156 } 155 }
157 156
158 157
159 void HeapProfiler::StartHeapAllocationsRecording() { 158 void HeapProfiler::StartHeapAllocationsRecording() {
160 StartHeapObjectsTracking(); 159 StartHeapObjectsTracking();
161 heap()->DisableInlineAllocation(); 160 heap()->DisableInlineAllocation();
162 is_tracking_allocations_ = true; 161 is_tracking_allocations_ = true;
163 DropCompiledCode();
164 snapshots_->UpdateHeapObjectsMap(); 162 snapshots_->UpdateHeapObjectsMap();
165 } 163 }
166 164
167 165
168 void HeapProfiler::StopHeapAllocationsRecording() { 166 void HeapProfiler::StopHeapAllocationsRecording() {
169 StopHeapObjectsTracking(); 167 StopHeapObjectsTracking();
170 heap()->EnableInlineAllocation(); 168 heap()->EnableInlineAllocation();
171 is_tracking_allocations_ = false; 169 is_tracking_allocations_ = false;
172 DropCompiledCode();
173 } 170 }
174 171
175 172
176 void HeapProfiler::DropCompiledCode() {
177 Isolate* isolate = heap()->isolate();
178 HandleScope scope(isolate);
179
180 if (FLAG_concurrent_recompilation) {
181 isolate->optimizing_compiler_thread()->Flush();
182 }
183
184 Deoptimizer::DeoptimizeAll(isolate);
185
186 Handle<Code> lazy_compile =
187 Handle<Code>(isolate->builtins()->builtin(Builtins::kLazyCompile));
188
189 heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,
190 "switch allocations tracking");
191
192 DisallowHeapAllocation no_allocation;
193
194 HeapIterator iterator(heap());
195 HeapObject* obj = NULL;
196 while (((obj = iterator.next()) != NULL)) {
197 if (obj->IsJSFunction()) {
198 JSFunction* function = JSFunction::cast(obj);
199 SharedFunctionInfo* shared = function->shared();
200
201 if (!shared->allows_lazy_compilation()) continue;
202 if (!shared->script()->IsScript()) continue;
203
204 Code::Kind kind = function->code()->kind();
205 if (kind == Code::FUNCTION || kind == Code::BUILTIN) {
206 function->set_code(*lazy_compile);
207 shared->set_code(*lazy_compile);
208 }
209 }
210 }
211 }
212
213
214 } } // namespace v8::internal 173 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-profiler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698