Issue 677223002: Remove some more frame-level scrolling machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 677223002: Remove some more frame-level scrolling machinery. (Closed)

Created:
6 years, 2 months ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, esprehn, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove some more frame-level scrolling machinery. This includes removing a bunch of scrolling methods and accessors on Window. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/96df18d1d5ff703031f4924324edfa4a73fc5ffe

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -216 lines)			Patch
M	sky/engine/core/dom/Element.cpp	View	4 chunks	+0 lines, -40 lines	0 comments	Download
M	sky/engine/core/dom/TreeScope.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/events/MouseRelatedEvent.cpp	View	2 chunks	+2 lines, -15 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.h	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	3 chunks	+1 line, -77 lines	0 comments	Download
M	sky/engine/core/frame/Window.idl	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sky/engine/public/web/WebFrame.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	sky/engine/web/tests/data/select_range_iframe_scroll.html	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	sky/engine/web/tests/data/select_range_scroll.html	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

6 years, 1 month ago (2014-10-25 06:16:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
96df18d1d5ff703031f4924324edfa4a73fc5ffe (presubmit successful).