Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 677223002: Remove some more frame-level scrolling machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index 3f15fe02ab11c2efc4c46ea24d44514739eb06ee..853fd3577f0e9efca135a7c8f38f9c1bc896592b 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -1385,11 +1385,6 @@ bool FrameView::isActive() const
return page && page->focusController().isActive();
}
-void FrameView::scrollTo(const IntSize& newOffset)
-{
- // FIXME(sky): remove
-}
-
void FrameView::invalidateScrollbarRect(Scrollbar*, const IntRect&)
{
// FIXME(sky): remove
@@ -1713,12 +1708,7 @@ IntPoint FrameView::convertFromRenderer(const RenderObject& renderer, const IntP
IntPoint FrameView::convertToRenderer(const RenderObject& renderer, const IntPoint& viewPoint) const
{
- IntPoint point = viewPoint;
-
- // Convert from FrameView coords into page ("absolute") coordinates.
- point += IntSize(scrollX(), scrollY());
-
- return roundedIntPoint(renderer.absoluteToLocal(point, UseTransforms));
+ return roundedIntPoint(renderer.absoluteToLocal(viewPoint, UseTransforms));
}
IntRect FrameView::convertToContainingView(const IntRect& localRect) const
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698