Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 677093002: Address EventRewriter Warning (Closed)

Created:
6 years, 2 months ago by jonross
Modified:
6 years, 2 months ago
Reviewers:
zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Address EventRewriter Warning The change https://codereview.chromium.org/653423004 introduced a warning. The Simple Chrome workflow treats all ChromeOS warnings as errors (https://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troubleshooting/building-chromium-browser?pli=1) This change initializes the variable to a default unknown value. BUG=424596 TEST=Compiled with Simple Chrome workflow. Ran existing EventRewriterTest Committed: https://crrev.com/d3ba46bfe646262a08822ae2456e38080a7023f5 Cr-Commit-Position: refs/heads/master@{#301117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jonross
Hi Zelidrag, I have created a follow up review to your changes to EventRewriter. A ...
6 years, 2 months ago (2014-10-24 14:55:09 UTC) #2
zel
lgtm
6 years, 2 months ago (2014-10-24 15:26:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677093002/1
6 years, 2 months ago (2014-10-24 15:29:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 16:14:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:15:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3ba46bfe646262a08822ae2456e38080a7023f5
Cr-Commit-Position: refs/heads/master@{#301117}

Powered by Google App Engine
This is Rietveld 408576698