Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 653423004: Suppress Xorg generated key repeat events for Hotrod remote (Closed)

Created:
6 years, 2 months ago by zel
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress Xorg generated key repeat events for Hotrod remote. BUG=424596 TEST=manual Committed: https://crrev.com/4425863d7cd81047942459be2fcb6b5f9d14f733 Cr-Commit-Position: refs/heads/master@{#301027}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : rebase #

Patch Set 4 : test fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -17 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.h View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 12 chunks +116 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
zel
6 years, 2 months ago (2014-10-17 14:19:27 UTC) #2
kpschoedel
https://codereview.chromium.org/653423004/diff/20001/chrome/browser/chromeos/events/event_rewriter.cc File chrome/browser/chromeos/events/event_rewriter.cc (right): https://codereview.chromium.org/653423004/diff/20001/chrome/browser/chromeos/events/event_rewriter.cc#newcode142 chrome/browser/chromeos/events/event_rewriter.cc:142: EventRewriter::DeviceType GetDeviceType(const std::string& device_name, I've been hoping to move ...
6 years, 2 months ago (2014-10-20 16:24:37 UTC) #4
Yusuke Sato
LGTM (sorry for the delay. I somehow missed the review request.)
6 years, 2 months ago (2014-10-20 22:17:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653423004/20001
6 years, 2 months ago (2014-10-20 23:21:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/25763)
6 years, 2 months ago (2014-10-21 02:40:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653423004/40001
6 years, 2 months ago (2014-10-23 20:19:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/4573)
6 years, 2 months ago (2014-10-23 23:34:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653423004/60001
6 years, 2 months ago (2014-10-24 01:08:48 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-24 02:01:17 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 02:01:55 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4425863d7cd81047942459be2fcb6b5f9d14f733
Cr-Commit-Position: refs/heads/master@{#301027}

Powered by Google App Engine
This is Rietveld 408576698