|
Record document mode histogram in UMA on every upload.
* Refactors the code to allow adding metrics as part of metrics provider
interface
* Implements a function in android_metrics_provider to record a new
histogram which records the current document mode. This is needed for
better analysis in Hera. I am adding a new histogram because the
semantics are a bit different from DocumentActivity.RunningMode. The
previous histogram is used only to record eligible devices that have
manually opted in or out. The new histogram will record for all devices
regardless of whether they could possibly be in document mode.
BUG= 418642
TBR=asvitkine@chromium.org,tedchoc@chromium.org
Review URL: https://codereview.chromium.org/658903002
Cr-Commit-Position: refs/heads/master@{#300375}
(cherry picked from commit 191028987824922561697fe1cf7056164495dfa9)
Conflicts:
chrome/browser/android/chrome_jni_registrar.cc
chrome/chrome_browser.gypi
Committed: https://chromium.googlesource.com/chromium/src/+/5edfb3f9fddecef20dacc54fabdc3c074ca503f5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+121 lines, -25 lines) |
Patch |
 |
M |
chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/android/chrome_jni_registrar.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/android/feature_utilities.h
|
View
|
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/android/feature_utilities.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/android_metrics_provider.h
|
View
|
|
2 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/android_metrics_provider.cc
|
View
|
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/chrome_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/chrome_metrics_service_client.cc
|
View
|
|
2 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/signin_status_metrics_provider.h
|
View
|
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/signin_status_metrics_provider.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/metrics/metrics_provider.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/metrics/metrics_service.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
tools/metrics/histograms/histograms.xml
|
View
|
|
2 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|