Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 676783003: Record document mode histogram in UMA on every upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index ab229004930c47e2b99efbd2bd2d79135f62413b..c3f2acf23ece19d74e90e57057694f4d48100bee 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -240,11 +240,6 @@ void ChromeMetricsServiceClient::CollectFinalMetrics(
DCHECK(!waiting_for_collect_final_metrics_step_);
waiting_for_collect_final_metrics_step_ = true;
-#if !defined(OS_CHROMEOS) && !defined(OS_IOS)
- // Record the signin status histogram value.
- signin_status_metrics_provider_->RecordSigninStatusHistogram();
-#endif
-
base::Closure callback =
base::Bind(&ChromeMetricsServiceClient::OnMemoryDetailCollectionDone,
weak_ptr_factory_.GetWeakPtr());
@@ -340,10 +335,9 @@ void ChromeMetricsServiceClient::Initialize() {
#endif // defined(OS_CHROMEOS)
#if !defined(OS_CHROMEOS) && !defined(OS_IOS)
- signin_status_metrics_provider_ =
- SigninStatusMetricsProvider::CreateInstance();
metrics_service_->RegisterMetricsProvider(
- scoped_ptr<metrics::MetricsProvider>(signin_status_metrics_provider_));
+ scoped_ptr<metrics::MetricsProvider>(
+ SigninStatusMetricsProvider::CreateInstance()));
#endif
}
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/signin_status_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698