Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ui/app_list/views/app_list_main_view.cc

Issue 676513003: Remove 1 pixel padding around app list main view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/call_add_contents_view_later
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/app_list_main_view.cc
diff --git a/ui/app_list/views/app_list_main_view.cc b/ui/app_list/views/app_list_main_view.cc
index 06cf0bcd7fdda3e3272e1c5c7245b0dc1fe35fe9..d043bb3d8088bf90eda634fa915769d5adf8cb30 100644
--- a/ui/app_list/views/app_list_main_view.cc
+++ b/ui/app_list/views/app_list_main_view.cc
@@ -36,9 +36,6 @@ namespace app_list {
namespace {
-// Border padding space around the bubble contents.
-const int kPadding = 1;
-
// The maximum allowed time to wait for icon loading in milliseconds.
const int kMaxIconLoadingWaitTimeInMs = 50;
@@ -113,9 +110,11 @@ AppListMainView::AppListMainView(AppListViewDelegate* delegate)
contents_view_(NULL),
contents_switcher_view_(NULL),
weak_ptr_factory_(this) {
- SetBorder(
- views::Border::CreateEmptyBorder(kPadding, kPadding, kPadding, kPadding));
- SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
+ SetLayoutManager(
+ new views::BoxLayout(views::BoxLayout::kVertical,
+ 0,
+ 0,
+ switches::IsExperimentalAppListEnabled() ? 0 : 1));
Matt Giuca 2014/10/23 05:16:34 I don't get why you added child spacing here.
calamity 2014/10/23 05:50:35 Compensates for the separator line. The contents v
search_box_view_ = new SearchBoxView(this, delegate);
views::View* container = new SearchBoxContainerView(this, search_box_view_);

Powered by Google App Engine
This is Rietveld 408576698