Remove 1 pixel padding around app list main view.

ui/app_list/views/app_list_main_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_main_view.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 18 matching lines @@
 #include "ui/views/border.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/widget/widget.h"
 
 namespace app_list {
 
 namespace {
 
-// Border padding space around the bubble contents.
-const int kPadding = 1;
-
 // The maximum allowed time to wait for icon loading in milliseconds.
 const int kMaxIconLoadingWaitTimeInMs = 50;
 
 // A view that holds another view and takes its preferred size. This is used for
 // wrapping the search box view so it still gets laid out while hidden. This is
 // a separate class so it can notify the main view on search box visibility
 // change.
 class SearchBoxContainerView : public views::View {
  public:
   SearchBoxContainerView(AppListMainView* host, SearchBoxView* search_box)
@@ skipping 54 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // AppListMainView:
 
 AppListMainView::AppListMainView(AppListViewDelegate* delegate)
     : delegate_(delegate),
       model_(delegate->GetModel()),
       search_box_view_(NULL),
       contents_view_(NULL),
       contents_switcher_view_(NULL),
       weak_ptr_factory_(this) {
-  SetBorder(
-      views::Border::CreateEmptyBorder(kPadding, kPadding, kPadding, kPadding));
-  SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
+  SetLayoutManager(
+      new views::BoxLayout(views::BoxLayout::kVertical,
+                           0,
+                           0,
+                           switches::IsExperimentalAppListEnabled() ? 0 : 1));

[Matt Giuca, 2014/10/23 05:16:34]

I don't get why you added child spacing here.

[calamity, 2014/10/23 05:50:35]

Compensates for the separator line. The contents view needs to be a pixel below
the line; removing the padding made it a pixel above. This is removed next patch
anyhow.

 
   search_box_view_ = new SearchBoxView(this, delegate);
   views::View* container = new SearchBoxContainerView(this, search_box_view_);
   if (switches::IsExperimentalAppListEnabled()) {
     container->SetBorder(
         views::Border::CreateEmptyBorder(kExperimentalWindowPadding,
                                          kExperimentalWindowPadding,
                                          0,
                                          kExperimentalWindowPadding));
   }
@@ skipping 212 matching lines @@
   // Resubmit the query via a posted task so that all observers for the
   // uninstall notification are notified.
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&AppListMainView::QueryChanged,
                  weak_ptr_factory_.GetWeakPtr(),
                  search_box_view_));
 }
 
 }  // namespace app_list