Remove 1 pixel padding around app list main view.

Remove 1 pixel padding around app list main view.

This CL removes the 1 pixel padding around the app list main view. This
subtly changes the layout of the app list by changing the padding of
certain elements.

The dimensions of the app list window are still the same.

This is being done in preparation for the new experimental app list
layout.

BUG=425444
Committed: https://crrev.com/cd52db3790eeef9229ffa2aca9df931e2be4a57a
Cr-Commit-Position: refs/heads/master@{#301073}

[calamity, 2014-10-23 02:11:40]

Patchset #1 (id:1) has been deleted

[calamity, 2014-10-23 02:12:05]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[calamity, 2014-10-23 02:12:05]

calamity@chromium.org changed required reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-10-23 05:16:34]

Ugh, it's too hard to understand all these little changes without discussing it.
brb.

Also, please be clear in the CL description about a) what the change to the old
and new app lists will be, and b) (briefly) why you are doing this.

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_main_view.cc (right):

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_main_view.cc:117:
switches::IsExperimentalAppListEnabled() ? 0 : 1));
I don't get why you added child spacing here.

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:74: const int
kExperimentalPreferredTileHeight = 90;
lol.

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:429: kExperimentalWindowPadding,
This seems to be that the old app list will use kExperimentalWindowPadding here.
It might be simpler and clearer to just have a separate SetBorder call for old
and new app list.

[calamity, 2014-10-23 05:50:35]

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_main_view.cc (right):

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_main_view.cc:117:
switches::IsExperimentalAppListEnabled() ? 0 : 1));
On 2014/10/23 05:16:34, Matt Giuca wrote:
> I don't get why you added child spacing here.

Compensates for the separator line. The contents view needs to be a pixel below
the line; removing the padding made it a pixel above. This is removed next patch
anyhow.

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/676513003/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:429: kExperimentalWindowPadding,
On 2014/10/23 05:16:34, Matt Giuca wrote:
> This seems to be that the old app list will use kExperimentalWindowPadding
here.
> It might be simpler and clearer to just have a separate SetBorder call for old
> and new app list.

Hmm. Fair enough. Done.

[Matt Giuca, 2014-10-23 06:32:14]

lgtm

[calamity, 2014-10-24 00:33:03]

The CQ bit was checked by calamity@chromium.org

[calamity, 2014-10-24 00:33:11]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2014-10-24 06:14:40]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-10-24 06:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676513003/60001

[commit-bot: I haz the power, 2014-10-24 07:52:25]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-10-24 07:53:04]

Patchset 3 (id:??) landed as
https://crrev.com/cd52db3790eeef9229ffa2aca9df931e2be4a57a
Cr-Commit-Position: refs/heads/master@{#301073}