Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 676373003: Cleanup CustomFontData after SVG Fonts removal (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup CustomFontData after SVG Fonts removal SVG Fonts were removed in: https://codereview.chromium.org/656913006 Remove some leftovers in CustomFontData that were meant for SVG Fonts. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184461

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/platform/fonts/CustomFontData.h View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rwlbuis
PTAL. pdr if you are not one of the chosen ones for platform/ review, can ...
6 years, 1 month ago (2014-10-27 14:50:14 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/676373003/diff/1/Source/platform/fonts/CustomFontData.h File Source/platform/fonts/CustomFontData.h (right): https://codereview.chromium.org/676373003/diff/1/Source/platform/fonts/CustomFontData.h#newcode38 Source/platform/fonts/CustomFontData.h:38: virtual void beginLoadIfNeeded() const { }; nit: since ...
6 years, 1 month ago (2014-10-27 14:59:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676373003/20001
6 years, 1 month ago (2014-10-27 15:10:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:31:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184461

Powered by Google App Engine
This is Rietveld 408576698