Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: Source/platform/fonts/CustomFontData.h

Issue 676373003: Cleanup CustomFontData after SVG Fonts removal (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/CustomFontData.h
diff --git a/Source/platform/fonts/CustomFontData.h b/Source/platform/fonts/CustomFontData.h
index 616179b691b2c873b5f89f321248b5ba76fbf308..b1c4fb53b60e488a23c4ab76248b5167a872e3e2 100644
--- a/Source/platform/fonts/CustomFontData.h
+++ b/Source/platform/fonts/CustomFontData.h
@@ -22,17 +22,12 @@
#define CustomFontData_h
#include "platform/PlatformExport.h"
-#include "platform/fonts/Glyph.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
-#include <unicode/uchar.h>
namespace blink {
-struct GlyphData;
-class GlyphPage;
class SimpleFontData;
-struct SimpleShaper;
class PLATFORM_EXPORT CustomFontData : public RefCounted<CustomFontData> {
public:
@@ -40,25 +35,18 @@ public:
virtual ~CustomFontData() { }
- virtual void beginLoadIfNeeded() const { };
+ virtual void beginLoadIfNeeded() const { }
virtual bool isLoading() const { return false; }
virtual bool isLoadingFallback() const { return false; }
virtual bool shouldSkipDrawing() const { return false; }
virtual void clearFontFaceSource() { }
virtual void initializeFontData(SimpleFontData*, float) { }
- virtual float widthForSVGGlyph(Glyph, float) const { return 0.0f; }
- virtual bool fillSVGGlyphPage(GlyphPage*, unsigned, unsigned, UChar*, unsigned, const SimpleFontData*) const { return false; }
- virtual bool applySVGGlyphSelection(SimpleShaper&, GlyphData&, bool, int, unsigned&) const { return false; }
protected:
CustomFontData() { }
};
-#define DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS(thisType, predicate) \
- template<typename T> inline thisType* to##thisType(const RefPtr<T>& customFontData) { return to##thisType(customFontData.get()); } \
- DEFINE_TYPE_CASTS(thisType, CustomFontData, customFontData, customFontData->predicate, customFontData.predicate)
-
} // namespace blink
#endif // CustomFontData_h
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698