Compile stdc++ library with both static and dynamic linking.

Compile stdc++ library with both static and dynamic linking. 
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1580 
TEST=compile glibc and check that libstdc++.so is present.

Committed: http://git.chromium.org/gitweb/?p=nacl-gcc.git;a=commit;h=18fae96

[halyavin, 2011-03-28 14:19:03]

On 2011/03/28 14:15:12, halyavin wrote:

[khim, 2011-03-28 14:42:11]

http://codereview.chromium.org/6761001/diff/3001/libtool.m4
File libtool.m4 (right):

http://codereview.chromium.org/6761001/diff/3001/libtool.m4#newcode2453
libtool.m4:2453:
library_names_spec='${libname}${release}-${versuffix:1}${shared_ext}
${libname}${release}${shared_ext}$major $libname${shared_ext}'
Let's not try to fix upstream inconsistencies.

We have enough our own ones.

[halyavin, 2011-03-28 14:50:06]

http://codereview.chromium.org/6761001/diff/3001/libtool.m4
File libtool.m4 (right):

http://codereview.chromium.org/6761001/diff/3001/libtool.m4#newcode2453
libtool.m4:2453:
library_names_spec='${libname}${release}-${versuffix:1}${shared_ext}
${libname}${release}${shared_ext}$major $libname${shared_ext}'
On 2011/03/28 14:42:11, khim wrote:
> Let's not try to fix upstream inconsistencies.
> 
> We have enough our own ones.

Done.

[khim, 2011-03-28 15:13:40]

LGTM

[Roland McGrath, 2011-04-07 00:05:40]

This was evidently not actually tested by updating tools/REVISIONS and doing a
try.  It breaks the build with a configure failure "Link tests are not allowed
after GCC_NO_EXECUTABLES."  It's necessary to dike out the
shlibpath_overrides_runpath test there.  The answer to the test is no unless
--enable-new-dtags is passed to ld by gcc by default (which AFAIK it is not).

[khimg, 2011-04-07 17:29:55]

On Thu, Apr 7, 2011 at 4:05 AM, <mcgrathr@chromium.org> wrote:

> This was evidently not actually tested by updating tools/REVISIONS and
> doing a
> try.  It breaks the build with a configure failure "Link tests are not
> allowed
> after GCC_NO_EXECUTABLES."  It's necessary to dike out the
> shlibpath_overrides_runpath test there.  The answer to the test is no
> unless
> --enable-new-dtags is passed to ld by gcc by default (which AFAIK it is
> not).
>
> http://codereview.chromium.org/6761001/
>

It was tested locally and it works on buildbots. I like the cleanup part,
but not the removal of shlibpath_overrides_runpath test: if linking does not
work then we'll have trouble with fortran backend later. Better to fix
linking issues...

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.