Add layout tests for hasPermission

Add layout tests for hasPermission

BUG=401424
Requires https://codereview.chromium.org/677073002

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185135

[Miguel Garcia, 2014-10-24 12:23:50]

miguelg@chromium.org changed reviewers:
+ mvanouwerkerk@google.com

[Miguel Garcia, 2014-10-24 12:24:07]

miguelg@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org
- mvanouwerkerk@google.com

[Michael van Ouwerkerk, 2014-10-24 12:53:01]

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging-has-permission.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:4: <script
src='../resources/js-test.js'></script>
nit: double quotes for html attributes please

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:8:
description('Tests for the Push API has permission method.');
hasPermission

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:34:
testPushHasPermission('granted');
Is this a tab for whitespace? Oh dear.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:41: function
testPushHasPermission(expectedStatus) {
Please separate the tests more cleanly by making this a zero-argument test. You
can just pass 'granted' into shouldBeEqualToString.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:44:
shouldBeEqualToString("status", expectedStatus);
nit: single quotes for js strings

[Peter Beverloo, 2014-10-24 13:03:23]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2014-10-24 13:03:24]

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging-has-permission.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:32: status  =
permissionStatus;
nit: double space before the =

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:33:
shouldBeEqualToString('status', expectedStatus);
shouldBeEqualToString('status', 'expectedStatus')

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:39:
testFailed('Error callback invoked unexpectedly.');
s/Error callback invoked/Promise rejected/.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:44:
shouldBeEqualToString("status", expectedStatus);
shouldBeEqualToString takes two literal strings which will be evalled, so this
should read:
  shouldBeEqualToString('status', 'expectedStatus');

[Miguel Garcia, 2014-10-31 17:04:47]

Thanks for the review! I had another pass now that most of the dependencies have
landed.

PTAL

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging-has-permission.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:4: <script
src='../resources/js-test.js'></script>
On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote:
> nit: double quotes for html attributes please

Done.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:8:
description('Tests for the Push API has permission method.');
On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote:
> hasPermission

Done.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:32: status  =
permissionStatus;
On 2014/10/24 13:03:24, Peter Beverloo wrote:
> nit: double space before the =

Done.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:33:
shouldBeEqualToString('status', expectedStatus);
On 2014/10/24 13:03:24, Peter Beverloo wrote:
> shouldBeEqualToString('status', 'expectedStatus')

Oh, here it still matters, see previous comment.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging-has-permission.html:39:
testFailed('Error callback invoked unexpectedly.');
Done

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
File LayoutTests/push_messaging/push-messaging.html (right):

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:34:
testPushHasPermission('granted');
On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote:
> Is this a tab for whitespace? Oh dear.

Done.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:34:
testPushHasPermission('granted');
On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote:
> Is this a tab for whitespace? Oh dear.

Done. Sorry about that, I configured eclipse properly for js development now.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:41: function
testPushHasPermission(expectedStatus) {
On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote:
> Please separate the tests more cleanly by making this a zero-argument test.
You
> can just pass 'granted' into shouldBeEqualToString.

Done.

https://codereview.chromium.org/676003002/diff/1/LayoutTests/push_messaging/p...
LayoutTests/push_messaging/push-messaging.html:44:
shouldBeEqualToString("status", expectedStatus);
On 2014/10/24 13:03:24, Peter Beverloo wrote:
> shouldBeEqualToString takes two literal strings which will be evalled, so this
> should read:
>   shouldBeEqualToString('status', 'expectedStatus');
> 
> 

Not that it matters now but expectedStatus is already of type string and unlike
the first argument it is Json.stringfy(ed) before processing it (see
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
so I actually think this was correct.

[Michael van Ouwerkerk, 2014-11-03 17:19:58]

lgtm

[Miguel Garcia, 2014-11-05 00:47:38]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2014-11-05 00:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676003002/20001

[Miguel Garcia, 2014-11-05 01:46:26]

The CQ bit was unchecked by miguelg@chromium.org

[Miguel Garcia, 2014-11-11 14:41:54]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2014-11-11 14:42:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676003002/40001

[commit-bot: I haz the power, 2014-11-11 16:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 16:45:33]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35843)

[Miguel Garcia, 2014-11-11 16:55:58]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2014-11-11 16:57:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676003002/40001

[commit-bot: I haz the power, 2014-11-11 17:35:55]

Committed patchset #3 (id:40001) as 185135