Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 677073002: Implement getPermissionStatus in MockWebPushClient (Closed)

Created:
6 years, 2 months ago by Miguel Garcia
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@push_has_permission
Project:
chromium
Visibility:
Public.

Description

Implement getPermissionStatus in MockWebPushClient Required for hasPermission LayoutTests BUG=401424 Committed: https://crrev.com/84b57b28f4766c4e411e6cc7125fc3400626a9f9 Cr-Commit-Position: refs/heads/master@{#302722}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/shell/renderer/test_runner/mock_web_push_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Miguel Garcia
6 years, 2 months ago (2014-10-24 12:23:28 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 2 months ago (2014-10-24 12:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677073002/20001
6 years, 1 month ago (2014-10-31 15:18:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21506)
6 years, 1 month ago (2014-10-31 15:22:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677073002/40001
6 years, 1 month ago (2014-10-31 17:08:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21528)
6 years, 1 month ago (2014-10-31 17:13:51 UTC) #11
Miguel Garcia
tkent@chromium.org: Please review changes in I just need a rubber stamp owners and most of ...
6 years, 1 month ago (2014-11-04 18:26:32 UTC) #13
tkent
lgtm
6 years, 1 month ago (2014-11-05 00:36:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677073002/40001
6 years, 1 month ago (2014-11-05 00:37:54 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 00:40:28 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/84b57b28f4766c4e411e6cc7125fc3400626a9f9 Cr-Commit-Position: refs/heads/master@{#302722}
6 years, 1 month ago (2014-11-05 00:41:11 UTC) #18
dcheng
This is making some layout tests fail. Is this expected? Normally, I'd rebase but the ...
6 years, 1 month ago (2014-11-05 01:42:41 UTC) #20
tkent
On 2014/11/05 01:42:41, dcheng wrote: > This is making some layout tests fail. Is this ...
6 years, 1 month ago (2014-11-05 01:46:00 UTC) #21
tkent
6 years, 1 month ago (2014-11-05 01:46:23 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/700993002/ by tkent@chromium.org.

The reason for reverting is: Broke a layout test,
push_messaging/push-messaging-api-surface.html.
.

Powered by Google App Engine
This is Rietveld 408576698