Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 6760017: Make SHA256 and SHA512 handle >UINT32_MAX data correctly (now with fix for ARM compilation) (Closed)

Created:
9 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Make SHA256 and SHA512 handle >UINT32_MAX data correctly (now with fix for ARM compilation) Change-Id: Iaa0c5675c07e9b54b2a389c53ed503e7a21ba731 BUG=chrome-os-partner:2912 TEST= 1) emerge-x86-generic vboot_reference 2) emerge-arm-generic vboot_reference 3) emerge-arm-generic vboot_reference-firmware 4) emerge-tegra2 vboot_reference-firmware 5) make && make runtests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e7f5c90

Patch Set 1 #

Patch Set 2 : arm firmware compilation fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M firmware/arch/arm/include/biosincludes.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M firmware/lib/cryptolib/include/sha.h View 1 chunk +2 lines, -2 lines 0 comments Download
M firmware/lib/cryptolib/sha2.c View 4 chunks +48 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
9 years, 8 months ago (2011-04-01 21:27:21 UTC) #1
Randall Spangler
9 years, 8 months ago (2011-04-04 16:08:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698