Issue 675853003: Fixed image-sizes-js-change flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 675853003: Fixed image-sizes-js-change flakiness (Closed)

Created:
6 years, 2 months ago by Yoav Weiss

Modified:
6 years, 2 months ago

Reviewers:
Mike West, aboxhall

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Fixed image-sizes-js-change flakiness Switched from using dumpResourceRequestCallbacks to using direct memoryCache APIs in internals. BUG=426041 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184348

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change-expected.txt	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Yoav Weiss

On 2014/10/24 10:08:32, Mike West wrote: > LGTM % patch failures. I should get myself ...

6 years, 2 months ago (2014-10-24 10:44:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675853003/20001

6 years, 2 months ago (2014-10-24 10:44:55 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-24 11:18:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 184348