LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html - Issue 675853003: Fixed image-sizes-js-change flakiness

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html

Issue 675853003: Fixed image-sizes-js-change flakiness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../hidpi/resources/srcset-helper.js"></script>	2 <script src="../../hidpi/resources/srcset-helper.js"></script>

3 <script src="../../../resources/js-test.js"></script>	3 <script src="../../../resources/js-test.js"></script>

4 <script src="resources/currentSrcHelper.js"></script>	4 <script src="resources/currentSrcHelper.js"></script>

5 <script>	5 <script>

6 if (window.testRunner)	6 if (window.testRunner)

7 testRunner.dumpAsText();	7 testRunner.dumpAsText();

	8

	9 if (internals)

	10 internals.evictAllResources();

8	11

9 function updateSrc() {	12 function updateSrc() {

10 var img = document.getElementById("foo");	13 var img = document.getElementById("foo");

11 // sizes must be set first, then srcset must be set, the 'src'	14 // sizes must be set first, then srcset must be set, the 'src'

12 // This will be fixed when image loading is done is "stable-state"	15 // This will be fixed when image loading is done is "stable-state"

13 img.sizes = "400px";	16 img.sizes = "400px";

14 img.srcset = "../../hidpi/resources/image-set-1x.png 200w, ../../hidpi/r esources/image-set-2x.png 400w, resources/image-set-4x.png 800w";	17 img.srcset = "../../hidpi/resources/image-set-1x.png 200w, ../../hidpi/r esources/image-set-2x.png 400w, resources/image-set-4x.png 800w";

15 img.src = "resources/blue-100-px-square.png"	18 img.src = "resources/blue-100-px-square.png"

16 }	19 }

17	20

18 addEventListener("DOMContentLoaded", function() {	21 addEventListener("DOMContentLoaded", function() {

19 if (window.testRunner && sessionStorage.pageReloaded)

20 testRunner.dumpResourceRequestCallbacks();

21 updateSrc();	22 updateSrc();

22 }, false);	23 }, false);

23 addEventListener("load", function() {	24 addEventListener("load", function() {

24 shouldBe('currentSrcFileName("foo")', '"image-set-4x.png"');	25 shouldBe('currentSrcFileName("foo")', '"image-set-4x.png"');

	26 if (internals) {

	27 shouldBeTrue('internals.isLoadingFromMemoryCache("resources/image-se t-4x.png")');

	28 shouldBeFalse('internals.isLoadingFromMemoryCache("../../hidpi/resou rces/image-set-2x.png")');

	29 shouldBeFalse('internals.isLoadingFromMemoryCache("../../hidpi/resou rces/image-set-1x.png")');

	30 shouldBeFalse('internals.isLoadingFromMemoryCache("resources/blue-10 0-px-square.png")');

	31 }

25 }, false);	32 }, false);

26 </script>	33 </script>

27 <img id="foo">	34 <img id="foo">

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change-expected.txt » ('j') | no next file with comments »