Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: minidump/minidump_crashpad_info_writer.h

Issue 675803002: Add MinidumpCrashpadModule, its list form, their writers, and their tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_crashpad_info_writer.h
diff --git a/minidump/minidump_crashpad_info_writer.h b/minidump/minidump_crashpad_info_writer.h
index f36c91f53515ae735e7d73a64f4db0624ec7add0..1deb1edec8c6e9399fd6079e5c58eecc5ab3a57a 100644
--- a/minidump/minidump_crashpad_info_writer.h
+++ b/minidump/minidump_crashpad_info_writer.h
@@ -23,29 +23,29 @@
#include "base/basictypes.h"
#include "minidump/minidump_extensions.h"
-#include "minidump/minidump_simple_string_dictionary_writer.h"
#include "minidump/minidump_stream_writer.h"
#include "minidump/minidump_writable.h"
-#include "util/file/file_writer.h"
namespace crashpad {
+class MinidumpCrashpadModuleListWriter;
+
//! \brief The writer for a MinidumpCrashpadInfo stream in a minidump file.
class MinidumpCrashpadInfoWriter final : public internal::MinidumpStreamWriter {
public:
MinidumpCrashpadInfoWriter();
~MinidumpCrashpadInfoWriter();
- //! \brief Arranges for MinidumpCrashpadInfo::simple_annotations to point to
- //! the MinidumpSimpleStringDictionaryWriter object to be written by \a
- //! simple_annotations.
+ //! \brief Arranges for MinidumpCrashpadInfo::crashpad_module_list to point to
+ //! the MinidumpCrashpadModuleList object to be written by \a
+ //! crashpad_module_list.
//!
- //! \a simple_annotations will become a child of this object in the overall
+ //! \a crashpad_module_list will become a child of this object in the overall
//! tree of internal::MinidumpWritable objects.
//!
//! \note Valid in #kStateMutable.
- void SetSimpleAnnotations(
- MinidumpSimpleStringDictionaryWriter* simple_annotations);
+ void SetCrashpadModuleList(
+ MinidumpCrashpadModuleListWriter* crashpad_module_list);
protected:
// MinidumpWritable:
@@ -59,7 +59,7 @@ class MinidumpCrashpadInfoWriter final : public internal::MinidumpStreamWriter {
private:
MinidumpCrashpadInfo crashpad_info_;
- MinidumpSimpleStringDictionaryWriter* simple_annotations_; // weak
+ MinidumpCrashpadModuleListWriter* crashpad_module_list_; // weak
DISALLOW_COPY_AND_ASSIGN(MinidumpCrashpadInfoWriter);
};

Powered by Google App Engine
This is Rietveld 408576698