Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: minidump/minidump_crashpad_info_writer.cc

Issue 675803002: Add MinidumpCrashpadModule, its list form, their writers, and their tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_crashpad_info_writer.cc
diff --git a/minidump/minidump_crashpad_info_writer.cc b/minidump/minidump_crashpad_info_writer.cc
index 2ad7291f841c8997b956b16fce2b18c578f14b1c..9e0b0750284b22a1f0ad1c28c4eb908ffe60e3f0 100644
--- a/minidump/minidump_crashpad_info_writer.cc
+++ b/minidump/minidump_crashpad_info_writer.cc
@@ -15,23 +15,24 @@
#include "minidump/minidump_crashpad_info_writer.h"
#include "base/logging.h"
+#include "minidump/minidump_crashpad_module_writer.h"
+#include "util/file/file_writer.h"
namespace crashpad {
MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter()
- : MinidumpStreamWriter(), crashpad_info_(), simple_annotations_() {
- crashpad_info_.size = sizeof(crashpad_info_);
- crashpad_info_.version = 1;
+ : MinidumpStreamWriter(), crashpad_info_(), crashpad_module_list_(nullptr) {
+ crashpad_info_.version = MinidumpCrashpadInfo::kVersion;
}
MinidumpCrashpadInfoWriter::~MinidumpCrashpadInfoWriter() {
}
-void MinidumpCrashpadInfoWriter::SetSimpleAnnotations(
- MinidumpSimpleStringDictionaryWriter* simple_annotations) {
+void MinidumpCrashpadInfoWriter::SetCrashpadModuleList(
+ MinidumpCrashpadModuleListWriter* crashpad_module_list) {
DCHECK_EQ(state(), kStateMutable);
- simple_annotations_ = simple_annotations;
+ crashpad_module_list_ = crashpad_module_list;
}
bool MinidumpCrashpadInfoWriter::Freeze() {
@@ -41,9 +42,9 @@ bool MinidumpCrashpadInfoWriter::Freeze() {
return false;
}
- if (simple_annotations_) {
- simple_annotations_->RegisterLocationDescriptor(
- &crashpad_info_.simple_annotations);
+ if (crashpad_module_list_) {
+ crashpad_module_list_->RegisterLocationDescriptor(
+ &crashpad_info_.crashpad_module_list);
}
return true;
@@ -60,8 +61,8 @@ MinidumpCrashpadInfoWriter::Children() {
DCHECK_GE(state(), kStateFrozen);
std::vector<MinidumpWritable*> children;
- if (simple_annotations_) {
- children.push_back(simple_annotations_);
+ if (crashpad_module_list_) {
+ children.push_back(crashpad_module_list_);
}
return children;

Powered by Google App Engine
This is Rietveld 408576698