Add MinidumpCrashpadModule, its list form, their writers, and their tests

Add MinidumpModuleCrashpadInfo, its list form, their writers, and their
test.

Move SimpleAnnotations from being a property of the minidump to being a
property of the module, matching the Snapshot interface.

TEST=minidump_test MinidumpCrashpadInfo.*:MinidumpCrashpadModule.*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/61af24848fe6965cdad46c0089295e91cc13b1e9

[Mark Mentovai, 2014-10-23 18:26:00]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2014-10-23 19:25:25]

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions.h
File minidump/minidump_extensions.h (right):

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:334: struct __attribute__((packed, aligned(4)))
MinidumpCrashpadModule {
I think "CrashpadModule" is a bit of a misnomer. Maybe
"MinidumpModuleCrashpadInfo" to go along with "MinidumpCrashpadInfo" ? It's kind
of a bikeshedy thing, and it would be a lot of renaming, though, so consider
this optional.

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:373: //! \brief The number of modules present in
the #modules array.
#crahspad_modules, although I think that's a bit of a misnomer as discussed
above.

[Mark Mentovai, 2014-10-23 19:47:53]

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions.h
File minidump/minidump_extensions.h (right):

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:334: struct __attribute__((packed, aligned(4)))
MinidumpCrashpadModule {
Robert Sesek wrote:
> I think "CrashpadModule" is a bit of a misnomer. Maybe
> "MinidumpModuleCrashpadInfo" to go along with "MinidumpCrashpadInfo" ? It's
kind
> of a bikeshedy thing, and it would be a lot of renaming, though, so consider
> this optional.

Not totally bikeshedding. I renamed everything. Now it’s clearer that it’s not a
“Crashpad module.”

https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:373: //! \brief The number of modules present in
the #modules array.
Robert Sesek wrote:
> #crahspad_modules, although I think that's a bit of a misnomer as discussed
> above.

Given the renaming, I simplified and am just calling these “modules” now.

[Mark Mentovai, 2014-10-23 21:16:16]

Patchset #3 (id:40001) has been deleted

[Robert Sesek, 2014-10-24 18:28:49]

LGTM

[Mark Mentovai, 2014-10-24 18:44:59]

Committed patchset #3 (id:60001) manually as
61af24848fe6965cdad46c0089295e91cc13b1e9 (presubmit successful).