Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: minidump/minidump_crashpad_info_writer.cc

Issue 675803002: Add MinidumpCrashpadModule, its list form, their writers, and their tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Update for https://codereview.chromium.org/679443002/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_crashpad_info_writer.h ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_crashpad_info_writer.cc
diff --git a/minidump/minidump_crashpad_info_writer.cc b/minidump/minidump_crashpad_info_writer.cc
index 2ad7291f841c8997b956b16fce2b18c578f14b1c..4d910b44b68bb69003908cea209e670bfc0efbc2 100644
--- a/minidump/minidump_crashpad_info_writer.cc
+++ b/minidump/minidump_crashpad_info_writer.cc
@@ -15,23 +15,24 @@
#include "minidump/minidump_crashpad_info_writer.h"
#include "base/logging.h"
+#include "minidump/minidump_crashpad_module_writer.h"
+#include "util/file/file_writer.h"
namespace crashpad {
MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter()
- : MinidumpStreamWriter(), crashpad_info_(), simple_annotations_() {
- crashpad_info_.size = sizeof(crashpad_info_);
- crashpad_info_.version = 1;
+ : MinidumpStreamWriter(), crashpad_info_(), module_list_(nullptr) {
+ crashpad_info_.version = MinidumpCrashpadInfo::kVersion;
}
MinidumpCrashpadInfoWriter::~MinidumpCrashpadInfoWriter() {
}
-void MinidumpCrashpadInfoWriter::SetSimpleAnnotations(
- MinidumpSimpleStringDictionaryWriter* simple_annotations) {
+void MinidumpCrashpadInfoWriter::SetModuleList(
+ MinidumpModuleCrashpadInfoListWriter* module_list) {
DCHECK_EQ(state(), kStateMutable);
- simple_annotations_ = simple_annotations;
+ module_list_ = module_list;
}
bool MinidumpCrashpadInfoWriter::Freeze() {
@@ -41,9 +42,8 @@ bool MinidumpCrashpadInfoWriter::Freeze() {
return false;
}
- if (simple_annotations_) {
- simple_annotations_->RegisterLocationDescriptor(
- &crashpad_info_.simple_annotations);
+ if (module_list_) {
+ module_list_->RegisterLocationDescriptor(&crashpad_info_.module_list);
}
return true;
@@ -60,8 +60,8 @@ MinidumpCrashpadInfoWriter::Children() {
DCHECK_GE(state(), kStateFrozen);
std::vector<MinidumpWritable*> children;
- if (simple_annotations_) {
- children.push_back(simple_annotations_);
+ if (module_list_) {
+ children.push_back(module_list_);
}
return children;
« no previous file with comments | « minidump/minidump_crashpad_info_writer.h ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698