Issue 675783006: minidump: existing virtual destructors → override

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 675783006: minidump: existing virtual destructors → override (Closed)

Created:
6 years, 2 months ago by Mark Mentovai

Modified:
6 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

minidump: Annotate existing virtual destructors that override a base class virtual destructor with “override”. TEST=minidump_test MinidumpContextWriter.*:MinidumpModuleWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/44a839614b83b4c140d1d20c877d9467ccb03905

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	minidump/minidump_context_writer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	minidump/minidump_module_writer.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 2 months ago (2014-10-23 22:42:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
44a839614b83b4c140d1d20c877d9467ccb03905 (presubmit successful).