minidump/minidump_module_writer.h - Issue 675783006: minidump: existing virtual destructors → override

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_writer.h

Issue 675783006: minidump: existing virtual destructors → override (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_module_writer.h

diff --git a/minidump/minidump_module_writer.h b/minidump/minidump_module_writer.h

index a745f16cf600bdb2b4d6bf09f52dbf2bc2a11192..f464e488e081fff94995e43a51a917a4ff889404 100644

--- a/minidump/minidump_module_writer.h

+++ b/minidump/minidump_module_writer.h

@@ -63,7 +63,7 @@ class MinidumpModuleCodeViewRecordPDBLinkWriter

protected:

MinidumpModuleCodeViewRecordPDBLinkWriter();

- virtual ~MinidumpModuleCodeViewRecordPDBLinkWriter();

+ ~MinidumpModuleCodeViewRecordPDBLinkWriter() override;

// MinidumpWritable:

size_t SizeOfObject() override;

@@ -96,7 +96,7 @@ class MinidumpModuleCodeViewRecordPDB20Writer final

: internal::MinidumpModuleCodeViewRecordPDBLinkWriter<

MinidumpModuleCodeViewRecordPDB20>() {}

- virtual ~MinidumpModuleCodeViewRecordPDB20Writer();

+ ~MinidumpModuleCodeViewRecordPDB20Writer() override;

//! \brief Sets MinidumpModuleCodeViewRecordPDB20::timestamp and

//! MinidumpModuleCodeViewRecordPDB20::age.

@@ -116,7 +116,7 @@ class MinidumpModuleCodeViewRecordPDB70Writer final

: internal::MinidumpModuleCodeViewRecordPDBLinkWriter<

MinidumpModuleCodeViewRecordPDB70>() {}

- virtual ~MinidumpModuleCodeViewRecordPDB70Writer();

+ ~MinidumpModuleCodeViewRecordPDB70Writer() override;

//! \brief Sets MinidumpModuleCodeViewRecordPDB70::uuid and

//! MinidumpModuleCodeViewRecordPDB70::age.

« no previous file with comments | « minidump/minidump_context_writer.h ('k') | no next file » | no next file with comments »