chrome/browser/ui/android/navigation_popup.cc - Issue 67573003: Android: moves chrome/ to use long for JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/navigation_popup.cc

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/navigation_popup.cc

diff --git a/chrome/browser/ui/android/navigation_popup.cc b/chrome/browser/ui/android/navigation_popup.cc

index fca009da75eedc821086e04c8a6bfc7b6e022a98..dd9dffd12cfaada1e600bd21d677f0fb93129b20 100644

--- a/chrome/browser/ui/android/navigation_popup.cc

+++ b/chrome/browser/ui/android/navigation_popup.cc

@@ -86,9 +86,9 @@ static jstring GetHistoryUrl(JNIEnv* env, jclass clazz) {

return ConvertUTF8ToJavaString(env, chrome::kChromeUIHistoryURL).Release();

}

-static jint Init(JNIEnv* env, jobject obj) {

+static jlong Init(JNIEnv* env, jobject obj) {

NavigationPopup* popup = new NavigationPopup(env, obj);

- return reinterpret_cast<jint>(popup);

+ return reinterpret_cast<intptr_t>(popup);

}

// static