Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 675513002: PepperVideoSourceHost: Change endianness of color format of frames sent to the plugin (Closed)

Created:
6 years, 2 months ago by magjed_chromium
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PepperVideoSourceHost: Change endianness of color format of frames sent to the plugin BUG=426020 Committed: https://crrev.com/7cb892ded5911f64dedd7ef0f55128065319370f Cr-Commit-Position: refs/heads/master@{#302247}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -50 lines) Patch
M content/renderer/media/webrtc/video_destination_handler.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.cc View 1 2 chunks +11 lines, -41 lines 0 comments Download
M content/renderer/pepper/pepper_video_source_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
tommi (sloooow) - chröme
lgtm
6 years, 2 months ago (2014-10-22 15:54:21 UTC) #2
magjed_chromium
Now that the effects plugin support this, are we ready to commit this CL?
6 years, 1 month ago (2014-10-30 10:49:13 UTC) #4
thorcarpenter
lgtm
6 years, 1 month ago (2014-10-30 16:54:00 UTC) #5
magjed_chromium
Adding owners: perkj and bbudge.
6 years, 1 month ago (2014-10-30 17:42:02 UTC) #7
bbudge
Pepper LGTM if your plugin is ready to endian-detect.
6 years, 1 month ago (2014-10-30 17:46:18 UTC) #8
tpsiaki
lgtm
6 years, 1 month ago (2014-10-30 18:11:19 UTC) #9
perkj_chrome
lgtm, note that tommi is also an owner.
6 years, 1 month ago (2014-10-31 08:42:46 UTC) #10
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-10-31 09:35:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675513002/20001
6 years, 1 month ago (2014-10-31 09:36:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 10:17:05 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 10:17:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cb892ded5911f64dedd7ef0f55128065319370f
Cr-Commit-Position: refs/heads/master@{#302247}

Powered by Google App Engine
This is Rietveld 408576698