Add cc::RendererSettings for use in with cc::Display

Add cc::RendererSettings for use in with cc::Display

The settings are taken from the ui::Compositor's LayerTreeSettings. Previously it was just using the default LayerTreeSettings, which can be suboptimal.

Committed: https://crrev.com/c5be44c904aa29a8a035819518c68db5a5cbe157
Cr-Commit-Position: refs/heads/master@{#305087}

[jbauman, 2014-10-24 02:01:39]

jbauman@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-10-24 04:37:45]

On 2014/10/24 02:01:39, jbauman wrote:

Seems like a bad dependency. Layer tree stuff is way higher level than anything
surfaces related.

[jbauman, 2014-10-25 00:40:10]

On 2014/10/24 04:37:45, jamesr wrote:
> On 2014/10/24 02:01:39, jbauman wrote:
> 
> Seems like a bad dependency. Layer tree stuff is way higher level than
anything
> surfaces related.

PTAL. I've added a RendererSettings class, and used it here instead.

[jamesr, 2014-10-27 05:11:38]

https://codereview.chromium.org/675083002/diff/80001/cc/output/renderer.h
File cc/output/renderer.h (right):

https://codereview.chromium.org/675083002/diff/80001/cc/output/renderer.h#new...
cc/output/renderer.h:11: #include "cc/trees/layer_tree_host.h"
can you get rid of this #include now?

https://codereview.chromium.org/675083002/diff/80001/cc/trees/layer_tree_sett...
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/675083002/diff/80001/cc/trees/layer_tree_sett...
cc/trees/layer_tree_settings.h:17: class CC_EXPORT LayerTreeSettings : public
RendererSettings {
can you make this embed a RendererSettings instead of inheriting from it? how
many callsites would this impact?

https://codereview.chromium.org/675083002/diff/80001/ui/compositor/compositor.h
File ui/compositor/compositor.h (right):

https://codereview.chromium.org/675083002/diff/80001/ui/compositor/compositor...
ui/compositor/compositor.h:272: const cc::LayerTreeSettings&
GetLayerTreeSettings() const;
the only caller needs the RendererSettings, not LTH settings - right? can you
make this the tighter type?

[jbauman, 2014-10-27 23:08:35]

On 2014/10/27 05:11:38, jamesr wrote:
> https://codereview.chromium.org/675083002/diff/80001/cc/output/renderer.h
> File cc/output/renderer.h (right):
> 
>
https://codereview.chromium.org/675083002/diff/80001/cc/output/renderer.h#new...
> cc/output/renderer.h:11: #include "cc/trees/layer_tree_host.h"
> can you get rid of this #include now?

Unfortunately this is still needed for RendererCapabilities.
> 
>
https://codereview.chromium.org/675083002/diff/80001/cc/trees/layer_tree_sett...
> File cc/trees/layer_tree_settings.h (right):
> 
>
https://codereview.chromium.org/675083002/diff/80001/cc/trees/layer_tree_sett...
> cc/trees/layer_tree_settings.h:17: class CC_EXPORT LayerTreeSettings : public
> RendererSettings {
> can you make this embed a RendererSettings instead of inheriting from it? how
> many callsites would this impact?

A bunch, but not that terrible. Fixed.
> 
>
https://codereview.chromium.org/675083002/diff/80001/ui/compositor/compositor.h
> File ui/compositor/compositor.h (right):
> 
>
https://codereview.chromium.org/675083002/diff/80001/ui/compositor/compositor...
> ui/compositor/compositor.h:272: const cc::LayerTreeSettings&
> GetLayerTreeSettings() const;
> the only caller needs the RendererSettings, not LTH settings - right? can you
> make this the tighter type?

Ok, sure.

[jbauman, 2014-11-07 02:19:56]

ping. Any other changes you want?

[jbauman, 2014-11-19 23:11:55]

ping

[jamesr, 2014-11-20 19:24:36]

lgtm

[jbauman, 2014-11-20 19:28:54]

jbauman@chromium.org changed reviewers:
+ boliu@chromium.org, piman@chromium.org

[jbauman, 2014-11-20 19:28:55]

also adding piman@ for ui/compositor OWNERS review and boliu@ for
android_webview OWNERS review.

[boliu, 2014-11-20 19:32:42]

android_webview lgtm

[piman, 2014-11-20 20:37:55]

lgtm

[jbauman, 2014-11-20 21:10:02]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-11-20 21:11:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675083002/160001

[commit-bot: I haz the power, 2014-11-20 22:17:22]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2014-11-20 22:18:05]

Patchset 9 (id:??) landed as
https://crrev.com/c5be44c904aa29a8a035819518c68db5a5cbe157
Cr-Commit-Position: refs/heads/master@{#305087}