Issue 675033002: Revert of Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 675033002: Revert of Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. (Closed)

Created:
6 years, 2 months ago by leviw_travelin_and_unemployed

Modified:
6 years, 2 months ago

Reviewers:
shreeramk, aboxhall, dmazzoni

CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. (patchset #1 id:1 of https://codereview.chromium.org/671003002/) Reason for revert: Broke the browser tests crbug.com/426608 Original issue's description: > Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. > > This is blink side CL to expose HTML pre tag in chromium side with proper MSAA+IA2 role. > > BUG=426053 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184300 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,shreeram.k@samsung.com NOTREECHECKS=true NOTRY=true BUG=426053 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184311

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -6 lines)			Patch
M	Source/core/accessibility/AXObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	public/web/WebAXEnums.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

leviw_travelin_and_unemployed

Created Revert of Adding PreRole in blink side to expose HTML pre tag with correct ...

6 years, 2 months ago (2014-10-23 23:30:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675033002/1

6 years, 2 months ago (2014-10-23 23:31:14 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-23 23:32:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184311