Make extensions that desire to act pop out if in overflow

chrome/browser/ui/views/toolbar/browser_action_view.h

Index: chrome/browser/ui/views/toolbar/browser_action_view.h
diff --git a/chrome/browser/ui/views/toolbar/browser_action_view.h b/chrome/browser/ui/views/toolbar/browser_action_view.h
index 50df4751c972adeffefa0ce058b58b48517273fc..1261deee27b3d3d79d1550739bc0530978ee94e3 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_view.h
+++ b/chrome/browser/ui/views/toolbar/browser_action_view.h
@@ -42,7 +42,7 @@ class BrowserActionView : public views::MenuButton,
   class Delegate : public views::DragController {
    public:
     // Returns the current web contents.
-    virtual content::WebContents* GetCurrentWebContents() = 0;
+    virtual content::WebContents* GetCurrentWebContents() const = 0;

[Peter Kasting, 2014/10/30 22:05:59]

Const functions should not return non-const pointers.  Either make the returned
pointer const, or leave this non-const.

[Devlin, 2014/10/31 17:44:09]

I thought this only applied to direct data members of the class, which this
doesn't return?  But, it's an easy enough workaround, so done.

[Peter Kasting, 2014/10/31 19:01:07]

There's a whole long physical/logical constness debate behind this one, but the
short answer is that it's too easy in too many situations for even non-member
returned pointers to be used to make changes to state that affects the
supposedly-const object.  Rather than try and debate whether such changes are
theoretically possible it's easiest to just have this simple rule.

 
     // Whether the container for this button is shown inside a menu.
     virtual bool ShownInsideMenu() const = 0;