Make extensions that desire to act pop out if in overflow

chrome/browser/ui/views/toolbar/browser_action_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_
 
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view_delegate.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 24 matching lines @@
 class BrowserActionView : public views::MenuButton,
                           public ToolbarActionViewDelegate,
                           public views::ButtonListener,
                           public content::NotificationObserver {
  public:
   // Need DragController here because BrowserActionView could be
   // dragged/dropped.
   class Delegate : public views::DragController {
    public:
     // Returns the current web contents.
-    virtual content::WebContents* GetCurrentWebContents() = 0;
+    virtual content::WebContents* GetCurrentWebContents() const = 0;

[Peter Kasting, 2014/10/30 22:05:59]

Const functions should not return non-const pointers.  Either make the returned
pointer const, or leave this non-const.

[Devlin, 2014/10/31 17:44:09]

I thought this only applied to direct data members of the class, which this
doesn't return?  But, it's an easy enough workaround, so done.

[Peter Kasting, 2014/10/31 19:01:07]

There's a whole long physical/logical constness debate behind this one, but the
short answer is that it's too easy in too many situations for even non-member
returned pointers to be used to make changes to state that affects the
supposedly-const object.  Rather than try and debate whether such changes are
theoretically possible it's easiest to just have this simple rule.

 
     // Whether the container for this button is shown inside a menu.
     virtual bool ShownInsideMenu() const = 0;
 
     // Notifies that a drag completed. Note this will only happen if the view
     // wasn't removed during the drag-and-drop process (i.e., not when there
     // was a move in the browser actions, since we re-create the views each
     // time we re-order the browser actions).
     virtual void OnBrowserActionViewDragDone() = 0;
 
@@ skipping 98 matching lines @@
 
   // Used to make sure we only register the command once.
   bool called_register_command_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserActionView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_