Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: pkg/analyzer/test/generated/all_the_rest.dart

Issue 674953002: Fix type of String.fromEnvironment() when the name is undefined. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/constant.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/all_the_rest.dart
diff --git a/pkg/analyzer/test/generated/all_the_rest.dart b/pkg/analyzer/test/generated/all_the_rest.dart
index c194f19f41a3cc51cc918760ce925b011ef9251b..8bfeefe1815d2f7088cf9ce1d2347f413ab1f6a5 100644
--- a/pkg/analyzer/test/generated/all_the_rest.dart
+++ b/pkg/analyzer/test/generated/all_the_rest.dart
@@ -7164,7 +7164,8 @@ class DeclaredVariablesTest extends EngineTestCase {
TestTypeProvider typeProvider = new TestTypeProvider();
String variableName = "var";
DeclaredVariables variables = new DeclaredVariables();
- _assertUnknownDartObject(variables.getBool(typeProvider, variableName));
+ _assertUnknownDartObject(typeProvider.boolType,
+ variables.getBool(typeProvider, variableName));
}
void test_getInt_invalid() {
@@ -7181,7 +7182,8 @@ class DeclaredVariablesTest extends EngineTestCase {
TestTypeProvider typeProvider = new TestTypeProvider();
String variableName = "var";
DeclaredVariables variables = new DeclaredVariables();
- _assertUnknownDartObject(variables.getInt(typeProvider, variableName));
+ _assertUnknownDartObject(typeProvider.intType,
+ variables.getInt(typeProvider, variableName));
}
void test_getInt_valid() {
@@ -7209,15 +7211,18 @@ class DeclaredVariablesTest extends EngineTestCase {
TestTypeProvider typeProvider = new TestTypeProvider();
String variableName = "var";
DeclaredVariables variables = new DeclaredVariables();
- _assertUnknownDartObject(variables.getString(typeProvider, variableName));
+ _assertUnknownDartObject(typeProvider.stringType,
+ variables.getString(typeProvider, variableName));
}
void _assertNullDartObject(TestTypeProvider typeProvider, DartObject result) {
JUnitTestCase.assertEquals(typeProvider.nullType, result.type);
}
- void _assertUnknownDartObject(DartObject result) {
+ void _assertUnknownDartObject(ParameterizedType expectedType,
+ DartObject result) {
JUnitTestCase.assertTrue((result as DartObjectImpl).isUnknown);
+ JUnitTestCase.assertEquals(expectedType, result.type);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/constant.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698