Fix type of String.fromEnvironment() when the name is undefined.

pkg/analyzer/test/generated/all_the_rest.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.all_the_rest_test;
 
 import 'dart:collection';
@@ skipping 7146 matching lines @@
     variables.define(variableName, "true");
     DartObject object = variables.getBool(typeProvider, variableName);
     JUnitTestCase.assertNotNull(object);
     JUnitTestCase.assertEquals(true, object.boolValue);
   }
 
   void test_getBool_undefined() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     DeclaredVariables variables = new DeclaredVariables();
-    _assertUnknownDartObject(variables.getBool(typeProvider, variableName));
+    _assertUnknownDartObject(typeProvider.boolType,
+        variables.getBool(typeProvider, variableName));
   }
 
   void test_getInt_invalid() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     DeclaredVariables variables = new DeclaredVariables();
     variables.define(variableName, "four score and seven years");
     _assertNullDartObject(
         typeProvider,
         variables.getInt(typeProvider, variableName));
   }
 
   void test_getInt_undefined() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     DeclaredVariables variables = new DeclaredVariables();
-    _assertUnknownDartObject(variables.getInt(typeProvider, variableName));
+    _assertUnknownDartObject(typeProvider.intType,
+        variables.getInt(typeProvider, variableName));
   }
 
   void test_getInt_valid() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     DeclaredVariables variables = new DeclaredVariables();
     variables.define(variableName, "23");
     DartObject object = variables.getInt(typeProvider, variableName);
     JUnitTestCase.assertNotNull(object);
     JUnitTestCase.assertEquals(23, object.intValue);
   }
 
   void test_getString_defined() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     String value = "value";
     DeclaredVariables variables = new DeclaredVariables();
     variables.define(variableName, value);
     DartObject object = variables.getString(typeProvider, variableName);
     JUnitTestCase.assertNotNull(object);
     JUnitTestCase.assertEquals(value, object.stringValue);
   }
 
   void test_getString_undefined() {
     TestTypeProvider typeProvider = new TestTypeProvider();
     String variableName = "var";
     DeclaredVariables variables = new DeclaredVariables();
-    _assertUnknownDartObject(variables.getString(typeProvider, variableName));
+    _assertUnknownDartObject(typeProvider.stringType,
+        variables.getString(typeProvider, variableName));
   }
 
   void _assertNullDartObject(TestTypeProvider typeProvider, DartObject result) {
     JUnitTestCase.assertEquals(typeProvider.nullType, result.type);
   }
 
-  void _assertUnknownDartObject(DartObject result) {
+  void _assertUnknownDartObject(ParameterizedType expectedType,
+                                DartObject result) {
     JUnitTestCase.assertTrue((result as DartObjectImpl).isUnknown);
+    JUnitTestCase.assertEquals(expectedType, result.type);
   }
 }
 
 
 class DirectoryBasedDartSdkTest extends JUnitTestCase {
   void fail_getDocFileFor() {
     DirectoryBasedDartSdk sdk = _createDartSdk();
     JavaFile docFile = sdk.getDocFileFor("html");
     JUnitTestCase.assertNotNull(docFile);
   }
@@ skipping 3939 matching lines @@
     } else {
       JUnitTestCase.assertNotNullMsg("script ${scriptIndex}", scriptSource);
       String actualExternalScriptName = scriptSource.shortName;
       JUnitTestCase.assertEqualsMsg(
           "script ${scriptIndex}",
           _expectedExternalScriptName,
           actualExternalScriptName);
     }
   }
 }