Remove async functionality from net::CookiePolicy.

Remove async functionality from net::CookiePolicy.

This lets us stop refcounting URLRequestHttpJob.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80660

[willchan no longer on Chromium, 2011-03-30 00:42:11]

eroman, jochen: review everything please

ananta: Backup for ChromeFrame knowledge. If I can gut more, let me know. There
seem to be some IPC message that may not be necessary, but I don't know. Or
maybe I cut too much out.

[jochen (gone - plz use gerrit), 2011-03-30 08:15:32]

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
File chrome/browser/net/chrome_cookie_policy.cc (right):

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:19: static const size_t
kMaxCompletionsPerHost = 10000;
still needed?

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:27:
switches::kBlockReadingThirdPartyCookies)) {}
I think the closing bracket should go on the next line, wdyt

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:40: if (rv != net::OK)
maybe also DCHECK for != ERR_IO_PENDING here?

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:79: return net::ERR_IO_PENDING;  //
Need to prompt.
NOTREACHED() && return ACCESS DENIED?

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
File chrome/browser/net/chrome_cookie_policy.h (right):

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.h:21: // We will only prompt the user
before setting a cookie.  We do not prompt the
update the comment please

[willchan no longer on Chromium, 2011-04-04 12:29:18]

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
File chrome/browser/net/chrome_cookie_policy.cc (right):

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:19: static const size_t
kMaxCompletionsPerHost = 10000;
On 2011/03/30 08:15:32, jochen wrote:
> still needed?

Done.

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:27:
switches::kBlockReadingThirdPartyCookies)) {}
On 2011/03/30 08:15:32, jochen wrote:
> I think the closing bracket should go on the next line, wdyt

There are two varying styles in Chromium and neither is outlawed by the
Google/Chromium style guides. Therefore, it's up to the maintainer of the
file/subsystem. I plan on taking ownership of this code as it's part of
chrome/browser/net, so I'm going to do what I like :)

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:40: if (rv != net::OK)
On 2011/03/30 08:15:32, jochen wrote:
> maybe also DCHECK for != ERR_IO_PENDING here?

Done.

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.cc:79: return net::ERR_IO_PENDING;  //
Need to prompt.
On 2011/03/30 08:15:32, jochen wrote:
> NOTREACHED() && return ACCESS DENIED?

Done.

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
File chrome/browser/net/chrome_cookie_policy.h (right):

http://codereview.chromium.org/6749044/diff/3001/chrome/browser/net/chrome_co...
chrome/browser/net/chrome_cookie_policy.h:21: // We will only prompt the user
before setting a cookie.  We do not prompt the
On 2011/03/30 08:15:32, jochen wrote:
> update the comment please

Done.

[jochen (gone - plz use gerrit), 2011-04-05 07:31:56]

LGTM

[willchan no longer on Chromium, 2011-04-05 16:07:18]

+jam to rubberstamp the few lines of content/ that have already been reviewed.

[jam, 2011-04-06 16:12:18]

lgtm

[commit-bot: I haz the power, 2011-04-06 16:15:02]

Can't apply patch for file chrome/browser/net/chrome_cookie_policy.cc.
patching file chrome/browser/net/chrome_cookie_policy.cc
Hunk #1 FAILED at 1.
1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/net/chrome_cookie_policy.cc.rej

[commit-bot: I haz the power, 2011-04-06 17:23:48]

Try job failure for 6749044-16001 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-04-06 18:22:46]

Change committed as 80660