Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 674873002: [ServiceWorkerCache] Call QuotaManager::NotifyStorageModified from Cache. (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
michaeln, falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] Call QuotaManager::NotifyStorageModified from Cache. With this call the quota manager can delete origins modified in the last X hours. Changes: * Plumb origin and QuotaManagerProxy through to ServiceWorkerCache. * Call NotifyStorageModified on SWCache::Put() and SWCache::Delete() with the delta being the number of content bytes written (not including caching structure overhead). * Update the tests to use a MockQuotaManagerProxy instead of passing a nullptr. Upstream of: https://codereview.chromium.org/672943002 BUG=420159 Committed: https://crrev.com/6cb43f40df3f3cf12bcecb20d713d6f5a5c894d6 Cr-Commit-Position: refs/heads/master@{#301086}

Patch Set 1 #

Patch Set 2 : Nits #

Patch Set 3 : Rebase #

Patch Set 4 : Allow null quota mgr #

Patch Set 5 : Fix refptr check #

Messages

Total messages: 7 (2 generated)
jkarlin
michaeln@chromium.org: Please review changes in all falken@chromium.org: Please review changes in all Thanks!
6 years, 2 months ago (2014-10-23 15:22:04 UTC) #2
falken
lgtm
6 years, 2 months ago (2014-10-24 02:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674873002/80001
6 years, 2 months ago (2014-10-24 12:13:23 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 2 months ago (2014-10-24 12:57:56 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 12:58:45 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6cb43f40df3f3cf12bcecb20d713d6f5a5c894d6
Cr-Commit-Position: refs/heads/master@{#301086}

Powered by Google App Engine
This is Rietveld 408576698