[ServiceWorkerCache] Return the real size of the cache in GetOriginUsage.

[ServiceWorkerCache] Return the real size of the cache in GetOriginUsage.

The size of the cache on disk is used if the backend is persistent, else the size of the entries in memory is returned.

Downstream of: https://codereview.chromium.org/674873002/

BUG=420159
Committed: https://crrev.com/05431b14d85d159302effdd81850f4376cc9ae15
Cr-Commit-Position: refs/heads/master@{#301097}

[jkarlin, 2014-10-23 17:53:26]

jkarlin@chromium.org changed reviewers:
+ falken@chromium.org, michaeln@chromium.org

[jkarlin, 2014-10-23 17:53:27]

michaeln@chromium.org: Please review changes in all

falken@chromium.org: Please review changes in all

Many thanks :)

[falken, 2014-10-24 02:24:34]

lgtm

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:973: disk_cache::Entry*
entry = NULL;
nullptr

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:981:
entries.push_back(entry);  // Open the entries without mutating them.
can you just add the entry's size here instead of using a separate vector?

[falken, 2014-10-24 03:14:15]

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:963: void
NotReachedCompletionCallback(int rv) {
can you move this helper into the nameless namespace?

[jkarlin, 2014-10-24 11:53:49]

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:963: void
NotReachedCompletionCallback(int rv) {
On 2014/10/24 03:14:15, falken wrote:
> can you move this helper into the nameless namespace?

Done. Thanks for catching that!

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:973: disk_cache::Entry*
entry = NULL;
On 2014/10/24 02:24:34, falken wrote:
> nullptr

Done.

https://codereview.chromium.org/672943002/diff/80001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:981:
entries.push_back(entry);  // Open the entries without mutating them.
On 2014/10/24 02:24:34, falken wrote:
> can you just add the entry's size here instead of using a separate vector?

Sadly, no. Getting the size mutates the ordering of entries (LRU) of the disk
cache (with a memory backend) which screws up the enumeration.

[jkarlin, 2014-10-24 13:44:52]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-10-24 13:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/672943002/120001

[commit-bot: I haz the power, 2014-10-24 14:29:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-10-24 14:30:31]

Patchset 7 (id:??) landed as
https://crrev.com/05431b14d85d159302effdd81850f4376cc9ae15
Cr-Commit-Position: refs/heads/master@{#301097}