Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 674583002: Make the background of the cast button semi-transparent (Closed)

Created:
6 years, 2 months ago by aberent
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Make the background of the cast button semi-transparent The overlay cast button had a semi-transparent CSS background color. Unfortunately the button image is treated in Blink as a background image, so this modified the image, rather than simply providing a background for it. As a result the cast button came out as grey on grey on pale backgrounds. Fix this by making the CSS background color transparent, and modifying the icon image itself to make its background semi-transparent. Since the CSS is in Blink the CSS change is in the Blink CL https://codereview.chromium.org/658353002 TBR=jam@chromium.org BUG=424180 Review URL: https://codereview.chromium.org/661833005 Cr-Commit-Position: refs/heads/master@{#300130} (cherry picked from commit fe5c903a0cb9cdf4e260fc37ac4cb4ebfe8a8cec) Committed: https://chromium.googlesource.com/chromium/src/+/3ea3c377914eb642ed9a4fec44b4aebce00739b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674583002/1
6 years, 2 months ago (2014-10-22 18:34:03 UTC) #3
aberent
6 years, 2 months ago (2014-10-22 18:39:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ea3c377914eb642ed9a4fec44b4aebce00739b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698