Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1815)

Issue 661833005: Make the background of the cast button semi-transparent (Closed)

Created:
6 years, 2 months ago by aberent
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, philipj_slow, whywhat
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the background of the cast button semi-transparent The overlay cast button had a semi-transparent CSS background color. Unfortunately the button image is treated in Blink as a background image, so this modified the image, rather than simply providing a background for it. As a result the cast button came out as grey on grey on pale backgrounds. Fix this by making the CSS background color transparent, and modifying the icon image itself to make its background semi-transparent. Since the CSS is in Blink the CSS change is in the Blink CL https://codereview.chromium.org/658353002 BUG=424180 Committed: https://crrev.com/fe5c903a0cb9cdf4e260fc37ac4cb4ebfe8a8cec Cr-Commit-Position: refs/heads/master@{#300130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
aberent
6 years, 2 months ago (2014-10-17 11:48:15 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-10-17 17:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661833005/1
6 years, 2 months ago (2014-10-17 17:17:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 18:05:45 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 18:07:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe5c903a0cb9cdf4e260fc37ac4cb4ebfe8a8cec
Cr-Commit-Position: refs/heads/master@{#300130}

Powered by Google App Engine
This is Rietveld 408576698