Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 674523002: Add ability to specify a different base dir path to record_wpr (Closed)

Created:
6 years, 2 months ago by rmistry
Modified:
6 years, 2 months ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ability to specify a different base dir path to record_wpr Motivation: Skia has its own set of page sets that are run on our bots. They live in a directory within Skia's repository. A similar change is going to be made to skpicture_printer in https://codereview.chromium.org/665193002/ BUG= Committed: https://crrev.com/01a90f9aae6eeaabd6c5419ca6042ed5a6633162 Cr-Commit-Position: refs/heads/master@{#301140}

Patch Set 1 : Initial upload #

Patch Set 2 : Add unittest #

Patch Set 3 : Uncomment test #

Total comments: 4

Patch Set 4 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rmistry
6 years, 2 months ago (2014-10-22 17:12:23 UTC) #2
ernstm
https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py#newcode128 tools/telemetry/telemetry/page/record_wpr.py:128: base_dir = self._options.custom_base_dir Please define a page_set_base_dir here that ...
6 years, 2 months ago (2014-10-23 21:21:31 UTC) #3
rmistry
https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py#newcode128 tools/telemetry/telemetry/page/record_wpr.py:128: base_dir = self._options.custom_base_dir On 2014/10/23 21:21:31, ernstm wrote: > ...
6 years, 2 months ago (2014-10-24 12:17:29 UTC) #4
ernstm
On 2014/10/24 12:17:29, rmistry wrote: > https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py > File tools/telemetry/telemetry/page/record_wpr.py (right): > > https://codereview.chromium.org/674523002/diff/40001/tools/telemetry/telemetry/page/record_wpr.py#newcode128 > ...
6 years, 2 months ago (2014-10-24 16:52:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674523002/60001
6 years, 2 months ago (2014-10-24 16:52:51 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-24 17:49:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 17:50:07 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/01a90f9aae6eeaabd6c5419ca6042ed5a6633162
Cr-Commit-Position: refs/heads/master@{#301140}

Powered by Google App Engine
This is Rietveld 408576698