Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 674523002: Add ability to specify a different base dir path to record_wpr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr_unittest.py
diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py
index 13709627714a71d6ed8121ba858f42f6ecaa4e2f..0197451bd66aa3ef8d94dd5cec17db1d3813ed88 100644
--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py
+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py
@@ -164,6 +164,20 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):
self.assertEqual(set(mock_benchmark.mock_page_set.pages),
results.pages_that_succeeded)
+ def testPageSetBaseDirFlag(self):
+ flags = [
+ '--page-set-base-dir', self._test_data_dir,
+ '--mock-benchmark-url', self._url,
+ '--browser', self._browser.browser_type,
+ ]
+ mock_benchmark = MockBenchmark()
+ wpr_recorder = record_wpr.WprRecorder(
+ 'non-existent-dummy-dir', mock_benchmark, flags)
+ results = wpr_recorder.CreateResults()
+ wpr_recorder.Record(results)
+ self.assertEqual(set(mock_benchmark.mock_page_set.pages),
+ results.pages_that_succeeded)
+
def testCommandLineFlags(self):
flags = [
'--page-repeat', '2',
« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698