Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 674413002: [fsp] Rename ObserveEntry with AddWatcher. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
benwells, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Rename ObserveEntry with AddWatcher. Since we may have more than one watcher, the previous naming didn't make sense. This patch changes all naming related to observing entries into creating watchers. TEST=Refactoring only. All current tests should pass. BUG=261491 Committed: https://crrev.com/39aaa52bf7843ecd64aad7faf5f0cfc5783bf161 Cr-Commit-Position: refs/heads/master@{#301596}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+730 lines, -1373 lines) Patch
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 4 chunks +6 lines, -7 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/observed_entry.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/observed_entry.cc View 1 chunk +0 lines, -38 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/add_watcher.h View 3 chunks +15 lines, -14 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/add_watcher.cc View 2 chunks +16 lines, -16 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/add_watcher_unittest.cc View 3 chunks +50 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/observe_directory.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/observe_directory.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/observe_directory_unittest.cc View 1 chunk +0 lines, -152 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/remove_watcher.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/remove_watcher.cc View 4 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/remove_watcher_unittest.cc View 4 chunks +30 lines, -30 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/unobserve_entry.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/unobserve_entry.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/operations/unobserve_entry_unittest.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 4 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 1 13 chunks +84 lines, -87 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 3 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h View 3 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 29 chunks +117 lines, -136 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry.cc View 1 8 chunks +59 lines, -64 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry_interface.h View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry_unittest.cc View 11 chunks +74 lines, -86 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 3 chunks +14 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 14 chunks +40 lines, -50 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/watcher.h View 1 chunk +76 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/watcher.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 4 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtomasz
@benwells: PTAL at IDL. @fukino: PTAL at the rest. It's a pretty much mechanical renaming ...
6 years, 1 month ago (2014-10-27 06:46:07 UTC) #3
fukino
On 2014/10/27 06:46:07, mtomasz wrote: > @benwells: PTAL at IDL. > @fukino: PTAL at the ...
6 years, 1 month ago (2014-10-27 10:29:36 UTC) #4
benwells
lgtm
6 years, 1 month ago (2014-10-27 21:10:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674413002/20001
6 years, 1 month ago (2014-10-28 08:12:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-28 11:53:00 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 11:54:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39aaa52bf7843ecd64aad7faf5f0cfc5783bf161
Cr-Commit-Position: refs/heads/master@{#301596}

Powered by Google App Engine
This is Rietveld 408576698