Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h

Issue 674413002: [fsp] Rename ObserveEntry with AddWatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h b/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
index 95d29b9b1f55a58db5b1e425552c29af06b7edb7..3c1ad6de4ed86ff5a202b1cc240c222988c44629 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
@@ -10,7 +10,7 @@
#include "base/callback.h"
#include "base/files/file_path.h"
-#include "chrome/browser/chromeos/file_system_provider/observed_entry.h"
+#include "chrome/browser/chromeos/file_system_provider/watcher.h"
namespace chromeos {
namespace file_system_provider {
@@ -19,18 +19,18 @@ class ProvidedFileSystemInfo;
class RequestManager;
// Observer class to be notified about changes happened to the provided file
-// system, especially observed entries.
+// system, including watched entries.
class ProvidedFileSystemObserver {
public:
struct Change;
- // Type of a change to an observed entry.
+ // Type of a change to a watched entry.
enum ChangeType { CHANGED, DELETED };
// Lust of changes.
typedef std::vector<Change> Changes;
- // Describes a change related to an observed directory.
+ // Describes a change related to a watched entry.
struct Change {
Change();
~Change();
@@ -39,26 +39,25 @@ class ProvidedFileSystemObserver {
ChangeType change_type;
};
- // Called when an observed entry is changed, including removals. |callback|
+ // Called when a watched entry is changed, including removals. |callback|
// *must* be called after the entry change is handled. Once all observers
- // call the callback, the tag will be updated and OnObservedEntryTagUpdated
+ // call the callback, the tag will be updated and OnWatcherTagUpdated
// called. The reference to |changes| is valid at least as long as |callback|.
- virtual void OnObservedEntryChanged(
- const ProvidedFileSystemInfo& file_system_info,
- const ObservedEntry& observed_entry,
- ChangeType change_type,
- const Changes& changes,
- const base::Closure& callback) = 0;
+ virtual void OnWatcherChanged(const ProvidedFileSystemInfo& file_system_info,
+ const Watcher& watcher,
+ ChangeType change_type,
+ const Changes& changes,
+ const base::Closure& callback) = 0;
- // Called after the tag value is updated for the observed entry.
- virtual void OnObservedEntryTagUpdated(
+ // Called after the tag value is updated for the watcher.
+ virtual void OnWatcherTagUpdated(
const ProvidedFileSystemInfo& file_system_info,
- const ObservedEntry& observed_entry) = 0;
+ const Watcher& watcher) = 0;
- // Called after the list of observed entries is changed.
- virtual void OnObservedEntryListChanged(
+ // Called after the list of watchers is changed.
+ virtual void OnWatcherListChanged(
const ProvidedFileSystemInfo& file_system_info,
- const ObservedEntries& observed_entries) = 0;
+ const Watchers& watchers) = 0;
};
} // namespace file_system_provider

Powered by Google App Engine
This is Rietveld 408576698