Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 674383002: Initial work on Dart bindings for Mojo. (Closed)

Created:
6 years, 1 month ago by zra
Modified:
5 years, 3 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Initial work on Dart bindings for Mojo. BUG=

Patch Set 1 #

Patch Set 2 : Work on bindings generator #

Patch Set 3 : Rm reletive paths from imports #

Patch Set 4 : Merge. Work on templates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4871 lines, -109 lines) Patch
M mojo/BUILD.gn View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/dart/BUILD.gn View 1 1 chunk +40 lines, -0 lines 0 comments Download
A mojo/dart/system/mojo_dart_embedder.cc View 1 chunk +133 lines, -0 lines 0 comments Download
A mojo/dart/tools/find_api_include_path.py View 1 chunk +16 lines, -0 lines 0 comments Download
M mojo/public/BUILD.gn View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
A mojo/public/dart/BUILD.gn View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A mojo/public/dart/bindings/lib/bindings.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
A mojo/public/dart/bindings/lib/src/client.dart View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download
A mojo/public/dart/bindings/lib/src/codec.dart View 1 chunk +720 lines, -0 lines 0 comments Download
A mojo/public/dart/bindings/lib/src/interface.dart View 1 1 chunk +69 lines, -0 lines 0 comments Download
A mojo/public/dart/bindings/test/codec_test.dart View 1 2 1 chunk +469 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/core.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/embedder.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/buffer.dart View 1 chunk +98 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/data_pipe.dart View 1 chunk +161 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/handle.dart View 1 chunk +153 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/handle_watcher.dart View 1 chunk +248 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/message_pipe.dart View 1 chunk +122 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/mojo_dart_system.cc View 1 chunk +799 lines, -0 lines 0 comments Download
A mojo/public/dart/system/lib/src/types.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A mojo/public/dart/system/tests/core_test.dart View 1 2 1 chunk +316 lines, -0 lines 0 comments Download
A mojo/public/dart/system/tests/event_handler_test.dart View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
A mojo/public/dart/tests/bindings_generation_test.dart View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download
A mojo/public/dart/tests/echo_test.dart View 1 2 1 chunk +145 lines, -0 lines 0 comments Download
A mojo/public/dart/utils/lib/expect.dart View 1 2 1 chunk +380 lines, -0 lines 0 comments Download
M mojo/public/mojo.gni View 1 chunk +3 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/dart_templates/enum_definition.tmpl View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 1 2 3 1 chunk +105 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/dart_templates/module_definition.tmpl View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A + mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 2 3 13 chunks +145 lines, -107 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 1 2 chunks +4 lines, -1 line 0 comments Download
A mojo/tools/dart_test_runner.dart View 1 2 1 chunk +130 lines, -0 lines 0 comments Download
M mojo/tools/mojob.sh View 1 2 6 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
Would you be willing to break this CL up into smaller, reviewable pieces?
6 years, 1 month ago (2014-11-05 00:09:58 UTC) #2
zra
6 years, 1 month ago (2014-11-05 00:19:54 UTC) #3 
On 2014/11/05 00:09:58, abarth wrote:
> Would you be willing to break this CL up into smaller, reviewable pieces?

Yes. The codec code is fairly small and standalone, so I'll start with it along
with the build/test changes, and then continue from there.

Powered by Google App Engine
This is Rietveld 408576698