mojo/public/tools/bindings/mojom.gni - Issue 674383002: Initial work on Dart bindings for Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 674383002: Initial work on Dart bindings for Mojo. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Merge. Work on templates. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_dart_generator.py ('k') | mojo/public/tools/bindings/mojom_bindings_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/mojom.gni

diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni

index 5a7932e1974b7fda422addfb69ee2bc89fbe9b63..5d8c1729ec775679354fc45fa8323a8f14f56cd7 100644

--- a/mojo/public/tools/bindings/mojom.gni

+++ b/mojo/public/tools/bindings/mojom.gni

@@ -65,10 +65,16 @@ template("mojom") {

"$generator_root/generators/js_templates/struct_definition.tmpl",

"$generator_root/generators/python_templates/module_macros.tmpl",

"$generator_root/generators/python_templates/module.py.tmpl",

+ "$generator_root/generators/dart_templates/module.lib.tmpl",

+ "$generator_root/generators/dart_templates/module_definition.tmpl",

+ "$generator_root/generators/dart_templates/enum_definition.tmpl",

+ "$generator_root/generators/dart_templates/struct_definition.tmpl",

+ "$generator_root/generators/dart_templates/interface_definition.tmpl",

"$generator_root/generators/mojom_cpp_generator.py",

"$generator_root/generators/mojom_js_generator.py",

"$generator_root/generators/mojom_java_generator.py",

"$generator_root/generators/mojom_python_generator.py",

+ "$generator_root/generators/mojom_dart_generator.py",

"$generator_root/pylib/mojom/__init__.py",

"$generator_root/pylib/mojom/error.py",

"$generator_root/pylib/mojom/generate/__init__.py",

@@ -97,6 +103,9 @@ template("mojom") {

generator_python_outputs = [

"{{source_gen_dir}}/{{source_name_part}}_mojom.py",

]

+ generator_dart_outputs = [

+ "{{source_gen_dir}}/{{source_name_part}}.mojom.dart",

+ ]

if (defined(invoker.visibility)) {

# Need to save this because the the target_name is overwritten inside the

@@ -116,7 +125,8 @@ template("mojom") {

outputs = generator_cpp_outputs +

generator_java_outputs +

generator_js_outputs +

- generator_python_outputs

+ generator_python_outputs +

+ generator_dart_outputs

args = [

"{{source}}",

"--use_chromium_bundled_pylibs",