Chromium Code Reviews

Issue 674373004: Drop RenderStyle-arg. from RenderSVGResource{Filter,Masker}::prepareEffect (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
Reviewers:
pdr., f(malita), Stephen Chennney, Timothy Loh
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Drop RenderStyle-arg. from RenderSVGResource{Filter,Masker}::prepareEffect It's unused in both cases. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184457

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+6 lines, -6 lines)
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/svg/SVGRenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments

Messages

Total messages: 7 (2 generated)
fs
6 years, 1 month ago (2014-10-27 14:49:44 UTC) #2
Timothy Loh
On 2014/10/27 14:49:44, fs wrote: lgtm
6 years, 1 month ago (2014-10-27 15:00:09 UTC) #3
f(malita)
lgtm
6 years, 1 month ago (2014-10-27 15:03:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674373004/1
6 years, 1 month ago (2014-10-27 15:04:18 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 15:22:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184457

Powered by Google App Engine