chrome/browser/extensions/api/sessions/sessions_apitest.cc - Issue 673933002: Correctly set tab.active not tab.selected in the chrome.sessions API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_apitest.cc

Issue 673933002: Correctly set tab.active not tab.selected in the chrome.sessions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/sessions/sessions_apitest.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_apitest.cc b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

index 0e0e8998dd1008816fa927c7562fc1687d72664c..b4ce679be05b7d5654063bf176286f2f3e9716e1 100644

--- a/chrome/browser/extensions/api/sessions/sessions_apitest.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

@@ -257,7 +257,11 @@ testing::AssertionResult CheckSessionModels(const base::ListValue& devices,

EXPECT_FALSE(tab->HasKey("id")); // sessions API does not give tab IDs

EXPECT_EQ(static_cast<int>(j), utils::GetInteger(tab, "index"));

EXPECT_EQ(0, utils::GetInteger(tab, "windowId"));

- EXPECT_EQ(true, utils::GetBoolean(tab, "pinned"));

+ EXPECT_EQ(j == 0, utils::GetBoolean(tab, "active"));

Nicolas Zea 2014/10/23 22:08:23 nit: comment that the first tab is always the tab

not at google - send to devlin 2014/10/23 22:15:10 Done.

+ EXPECT_FALSE(utils::GetBoolean(tab, "selected"));

+ EXPECT_FALSE(utils::GetBoolean(tab, "highlighted"));

+ EXPECT_FALSE(utils::GetBoolean(tab, "incognito"));

+ EXPECT_TRUE(utils::GetBoolean(tab, "pinned"));

EXPECT_EQ("http://foo/1", utils::GetString(tab, "url"));

EXPECT_EQ("MyTitle", utils::GetString(tab, "title"));

EXPECT_EQ("http://foo/favicon.ico", utils::GetString(tab, "favIconUrl"));

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_api.cc ('k') | no next file » | no next file with comments »