Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: components/sessions/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clobber. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/BUILD.gn
diff --git a/components/sessions/BUILD.gn b/components/sessions/BUILD.gn
index f2ada0545aee1890d319f722324ae5c0f51b0e5d..12a51112e0a5cc03aad09f44e6e6809ab736a0d2 100644
--- a/components/sessions/BUILD.gn
+++ b/components/sessions/BUILD.gn
@@ -2,41 +2,56 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/features.gni")
+import("//third_party/protobuf/proto_library.gni")
+import("//tools/grit/grit_rule.gni")
+
if (is_android) {
import("//build/config/android/config.gni")
}
-component("sessions") {
- sources = [
- # TODO(rohitrao): Split this target into three separate core, content,
- # and web targets.
- "content/content_serialized_navigation_builder.cc",
- "content/content_serialized_navigation_builder.h",
- "content/content_serialized_navigation_driver.cc",
- "content/content_serialized_navigation_driver.h",
- "core/serialized_navigation_driver.h",
- "serialized_navigation_entry.cc",
- "serialized_navigation_entry.h",
- "session_id.cc",
- "session_id.h",
- ]
+if (is_component_build) {
+ component("sessions") {
+ deps = [
+ "//components/sessions/core",
+ ]
- defines = [ "SESSIONS_IMPLEMENTATION" ]
+ if (!is_ios) {
+ deps += [ "//components/sessions/content" ]
+ }
+ }
+ group("sessions_core") {
blundell 2014/10/24 07:23:14 What is this?
rohitrao (ping after 24h) 2014/10/24 12:18:29 I'm not really sure, I copied it from components/p
+ deps = [ ":sessions" ]
+ }
- deps = [
- "//base",
- "//base/third_party/dynamic_annotations",
- "//content/public/browser",
- "//skia",
- "//ui/base",
- "//url",
- ]
+ if (!is_ios) {
+ group("sessions_content") {
blundell 2014/10/24 07:23:13 and this?
+ deps = [ ":sessions" ]
+ }
+ }
+} else { # Compile to separate libraries.
+ group("sessions") {
+ deps = [
+ ":sessions_core",
+ ":sessions_content",
+ ]
- if (!is_android || !is_android_webview_build) {
- deps += [ "//sync" ]
+ if (!is_ios) {
+ deps += [ ":sessions_content" ]
+ }
+ }
+ component("sessions_core") {
+ deps = [ "//components/sessions/core" ]
+ }
+
+ if (!is_ios) {
+ component("sessions_content") {
+ deps = [ "//components/sessions/content" ]
+ }
}
}
+
static_library("test_support") {
testonly = true
sources = [

Powered by Google App Engine
This is Rietveld 408576698